[PATCH] D49576: [llvm-objcopy] Add basic support for --rename-section

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked 3 inline comments as done.
rupprecht added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:597
+    if (!StringRef(Arg->getValue()).contains('='))
+      error("Bad format for --rename-section");
+    auto Old2New = StringRef(Arg->getValue()).split('=');
----------------
alexshap wrote:
> these error messages need to be tested (lines 597, 600)
600 should already be covered by --check-prefix=MULTIPLE-RENAMES in test/tools/llvm-objcopy/rename-section.test, let me know if you meant something else.
Added a test case for bad format.


Repository:
  rL LLVM

https://reviews.llvm.org/D49576