[PATCH] D49517: [WebAssembly] Handle return type conversions in FixFunctionBitcasts pass

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 17:08:28 PDT 2018


sbc100 added a comment.

When you say not all types are valid to cast to all others.. how would I know which are valid?  And how would this code fail if they are invalid?  Would llvm bail out during the call to getCastOpcode()?

I ideally we would never actually produce invalid wasm and prefer to fail to compile.. but perhaps that should be done later on during codegen rather that during this pass?


Repository:
  rL LLVM

https://reviews.llvm.org/D49517





More information about the llvm-commits mailing list