[PATCH] D47475: [Local] Make DoesKMove required for combineMetadata.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D47475#1168792, @efriedma wrote:

> > Also it allows sinking a load and preserving the nonnull metadata, if there are loads in all predecessors and they all have nonnull.
>
> I would prefer to handle that specific case in some different way; it's not the same sort of reasoning.  In the CSE case, it doesn't matter whether J has nonnull metadata.


Sounds good. Would it be OK to make combineMetadata stricter in that respect for the relevant metadata kinds in a follow up commit? Doing it step-by-step seems slightly easier to me, but I could also fold it into this or the previous patch if you think that's better.


https://reviews.llvm.org/D47475