[PATCH] D49512: [CodeGenPrepare] Remove instruction from PromotedInsts if we have seen it multi times
Guozhi Wei via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 19 15:24:06 PDT 2018
Carrot added a comment.
In https://reviews.llvm.org/D49512#1167869, @grandinj wrote:
> from someone who is just an observer: What happens when we see IsSExt types
>
> A
> B
> A
>
> ?
> Then the last one will re-insert A, which is probably not what you want.
Good catch!
So we should record zero/sign/both extension types of an instruction instead of delete it.
Repository:
rL LLVM
https://reviews.llvm.org/D49512
More information about the llvm-commits
mailing list