[PATCH] D49408: [SCCP] Don't use markForcedConstant on branch conditions.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: test/Transforms/SCCP/ipsccp-paramstate-forcedconst.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -S -ipsccp | FileCheck %s
----------------
fhahn wrote:
> nit: forcedconstant is not involved any more, maybe we should drop it from the name to avoid confusion or combine it with return-zapped.ll to something like ipsccp-branch-condition-unknown-initially.ll?
K


================
Comment at: test/Transforms/SCCP/return-zapped.ll:9
+; becomes overdefined. We cannot change the return value of @testf to undef,
+; because we failed to replace the result of the call with true.
+define void @test1() {
----------------
I'll fix this comment before merging.


================
Comment at: test/Transforms/SCCP/return-zapped.ll:46
+
+; Call sites in unreachable blocks should not be a problem.
+; CHECK-LABEL: define i1 @test2() {
----------------
fhahn wrote:
> Is this test valuable with the new approach?
I don't think it does any harm to keep it.


Repository:
  rL LLVM

https://reviews.llvm.org/D49408