[PATCH] D49493: [DebugInfo] Reduce debug_str_offsets section size

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Couple of other possible ideas:

splitting the indexed and unindexed functions into separate, named functions for clarity (alternatively - 'named boolean' (so they don't have to be commented) by adding an enum class for legibility).

Also, possible that there could be assert/runtime checking to ensure that the caller who requests an unindexed string - could use a PointerIntPair & squirrel a boolean in the low bit to say "this DwarfStringPoolEntryRef can not provide an index"? (so that there's no chance of weird race conditions that would hide bugs - ask for an unindexed string, then later ask for that same string indexed, then the first user can request the index without a failure - until later on the second user goes away/changes/etc)


Repository:
  rL LLVM

https://reviews.llvm.org/D49493