[PATCH] D49508: [Sema] Expr::skipRValueSubobjectAdjustments(): record skipped NoOp casts.

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 11:36:44 PDT 2018


rjmccall added a comment.

Hmm.  I think the approach of flagging ICEs that are semantically part of an explicit cast is probably a better representation for tools across the board.

If we *are* going to do it this way, though, I think you should (1) make the collection of skipped expressions optional and (2) collect *all* the skipped expressions, not just no-op casts.


Repository:
  rC Clang

https://reviews.llvm.org/D49508





More information about the llvm-commits mailing list