[PATCH] D49522: [DWARF v5] Don't emit duplicate DW_AT_rnglists_base and address review comments from previous review

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 11:35:51 PDT 2018


wolfgangp updated this revision to Diff 156330.
wolfgangp added a comment.

Review comments: Have emitRnglistsTableHeader() return the end symbol instead of setting it as a reference parameter.

Found a problem with the fix to duplite emission of DW_AT_rnglists_base and corrected it. Apologies.


https://reviews.llvm.org/D49522

Files:
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  test/DebugInfo/X86/rnglists_base_attr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49522.156330.patch
Type: text/x-patch
Size: 11478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180719/aabca1bd/attachment.bin>


More information about the llvm-commits mailing list