[PATCH] D48850: [GISel]: Testing LegalizerHelper using Unit tests

[Justin Bogner via Phabricator via llvm-commits]

bogner added a comment.

Conceptually this looks pretty good, but we should definitely sink a lot of this implementation into lib/Support/FileCheck.cpp and anything that stays in the header should be moved into the llvm:: namespace, since this is library code now. There are a lot of overly generic names in the implementation as is (like Pattern), which is fine as long as they end up in anonymous namespaces in FileCheck.cpp but will have to be changed if they're really part of the API.


Repository:
  rL LLVM

https://reviews.llvm.org/D48850