[PATCH] D49552: Add a Microsoft Demangler library and utility.

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:79-89
+// Storage classes
+enum Qualifiers : uint8_t {
+  eQualNone = 0,
+  eQualConst = 1 << 0,
+  eQualVolatile = 1 << 1,
+  eQualFar = 1 << 2,
+  eQualHuge = 1 << 3,
----------------
Doesn't seem to be in the LLVM style.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:158
+  Virtual = 1 << 5,
+  FFar = 1 << 6,
+};
----------------
FFar?


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:274
+  // special name @[0-9]. This is a storage for the first 10 BackReferences.
+  StringView BackReferences[10];
+  size_t BackRefCount = 0;
----------------
std::array?


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:578
+  case '_': {
+    switch (MangledName.popFront()) {
+    case '0':
----------------
Can't this blow up if there isn't a character left?


https://reviews.llvm.org/D49552