[lld] r337460 - [ELF] - Eliminate dead code. NFC.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 07:39:56 PDT 2018


Author: grimar
Date: Thu Jul 19 07:39:56 2018
New Revision: 337460

URL: http://llvm.org/viewvc/llvm-project?rev=337460&view=rev
Log:
[ELF] - Eliminate dead code. NFC.

Code was dead because we call postThunkContents only for SHT_SYMTAB.

Modified:
    lld/trunk/ELF/SyntheticSections.cpp

Modified: lld/trunk/ELF/SyntheticSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=337460&r1=337459&r2=337460&view=diff
==============================================================================
--- lld/trunk/ELF/SyntheticSections.cpp (original)
+++ lld/trunk/ELF/SyntheticSections.cpp Thu Jul 19 07:39:56 2018
@@ -1849,8 +1849,7 @@ void SymbolTableBaseSection::finalizeCon
 // symbol. That is convenient for purpose of identifying where are local symbols
 // coming from.
 void SymbolTableBaseSection::postThunkContents() {
-  if (this->Type == SHT_DYNSYM)
-    return;
+  assert(this->Type == SHT_SYMTAB);
 
   // Move all local symbols before global symbols.
   auto E = std::stable_partition(




More information about the llvm-commits mailing list