[PATCH] D49542: DwarfDebug: Reduce duplication in addAccel*** methods

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

> This technically isn't NFC, because it changes the StringPool used for
>  apple tables in the DWO case (now it uses the main file like DWARF v5
>  instead of the DWO file). However, that shouldn't matter, as DWO is not
>  a thing on apple targets (clang frontend simply ignores -gsplit-dwarf).

In fact I would go as far as to say this makes things more correct. Back when apple tables were hooked up to -glldb, I tried to use them on linux with -gsplit-dwarf. The compilation broke because we couldn't perform the split step (it wanted to keep the apple tables in the main file, but they were linked to the debug_str.dwo section).


Repository:
  rL LLVM

https://reviews.llvm.org/D49542