[PATCH] D49489: [VPlan] VPlan version of InterleavedAccessInfo.

Robin Kruppe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 05:39:31 PDT 2018


rkruppe added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlan.cpp:599
+      if (NewIGIter == Old2New.end())
+        Old2New[IG] = new InterleaveGroup<VPInstruction>(
+            IG->getFactor(), IG->isReverse(), IG->getAlignment());
----------------
It doesn't seem like this memory is freed anywhere.

Reading D49491 it seems to me that the InterleaveGroups allocated here are only needed while the `VPInterleavedAccessInfo` object is alive, so it could free them in its destructor (or even better, store `unique_ptr`s that take care of that automatically).


https://reviews.llvm.org/D49489





More information about the llvm-commits mailing list