[PATCH] D49473: [MSan] pull insertShadowCheck() into getShadowOriginPtr(). NFC
Alexander Potapenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 19 05:16:04 PDT 2018
glider added a comment.
In https://reviews.llvm.org/D49473#1166913, @eugenis wrote:
> Could you simply pass the pointer shadow value as an argument to the runtime call in the kernel, and keep userspace instrumentation as it is?
This'll cost us two registers (for the pointer shadow value and an origin) and is also conceptually incorrect, as calculation of the shadow for a given address should be considered a use of that address and shouldn't precede its checks for validity.
https://reviews.llvm.org/D49473
More information about the llvm-commits
mailing list