[PATCH] D49500: [DWARF v5] Refactor range lists dumping (NFC except for spelling changes in dump output).
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 19 02:53:52 PDT 2018
JDevlieghere added a comment.
Can you run clang-format on this patch?
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFListTable.h:89
+ /// The name of the section the list is located in.
+ const char *SectionName;
+ /// A characterization of the list for dumping purposes, e.g. "range" or
----------------
Should we use a StringRef for these?
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFListTable.h:162
+
+ void dump(raw_ostream &OS, DIDumpOptions DumpOpts) const;
+
----------------
We usually make the DIDumpOptions optional by providing a default value (`= {}`)
https://reviews.llvm.org/D49500
More information about the llvm-commits
mailing list