[PATCH] D49371: [ELF] - Do not produce broken output when amount of sections is > ~65k

Thu Jul 19 00:29:22 PDT 2018

grimar added a comment.

In https://reviews.llvm.org/D49371#1166746, @ruiu wrote:

> Do you really need this? That the spec says something doesn't always mean that we need it. I'm afraid that all these nitpicky details would accumulate and make the entire program hard to read. Even though I'm not against "doing it right", I really want you to show some examples to convince others that we need it.

Hi Rui, this was https://bugs.llvm.org//show_bug.cgi?id=38119. We produced broken output previously and user faced it.
Tools did not allow to dump the content correctly and things looked like some kind of memory corruption.

> Hm, maybe this particular patch is too easy that it doesn't have to be reverted, but please allow me time to review your patches.
>  I believe there's no need to hurry to submit these kind of changes.

Sure. Thanks.

> (I believe you've got my vacation responder email.)

(FYI I did not get any responder emails from you, I guess because using phab and not direct mails may be. Not sure)

Repository:
  rL LLVM

https://reviews.llvm.org/D49371