[PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

[Hui Huang via Phabricator via llvm-commits]

Hui added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:587
+    // only do this once.
+    if (result->GetID() == type_uid) {
+      pdb->CompleteRecordTypeForPDBSymbol(*pdb_type, result);
----------------
aleksandr.urakov wrote:
> I don't fully understand, please, explain me, when does this can be `false`?
All types are parsed by symbol->getSymIndexId() except PDBSymbolBaseClass and PDBSymbolFunc symbols they are parsed by symbol->getTypeId(). After completion,  Clang type of PDBSymbolBaseClass is reset with  symbol->getSymIndexId().


https://reviews.llvm.org/D49410