[PATCH] D49405: Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte)

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 17:28:17 PDT 2018


pcc added a comment.

This looks fine if Dean is happy.



================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:775
+    // Experiments of different caps with Chromium on both x64 and ARM64
+    // have shown that now the 32-byte cap generates the smallest binary on 
+    // both platforms while different caps yield similar performance.
----------------
Remove the word "now".


https://reviews.llvm.org/D49405





More information about the llvm-commits mailing list