[PATCH] D49522: [DWARF v5] Don't emit duplicate DW_AT_rnglists_base and address review comments from previous review

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp created this revision.
wolfgangp added reviewers: dblaikie, probinson, JDevlieghere.
Herald added a subscriber: aprantl.

This is a follow-on to https://reviews.llvm.org/D49214, which received some additional review comments after closing.

Addresses the following:

1. Fixing a bug with duplicate emission of DW_AT_rnglists_base with test case.
2. Fixing a somewhat stale comment to constructSkeletonCU() and moving it to the header.
3. Refactor DwarfDebug::emitDebugRanges() to handle both v5 and prior.
4. Some minor grammatical tweaks.

Dave already handled the base address specifier issues mentioned in the other review, as well as some test coverage additions in a different revision. Thanks!


https://reviews.llvm.org/D49522

Files:
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  test/DebugInfo/X86/rnglists_base_attr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49522.156177.patch
Type: text/x-patch
Size: 11315 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180718/bee8b5f7/attachment.bin>