[PATCH] D47475: [Local] Make KDominatesJ required for combineMetadata.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 16:06:43 PDT 2018


efriedma added a comment.

Given that it's UB to violate nonnull metadata, the metadata on J doesn't actually matter; the important question is whether K moves.  If it does, we have to strip the nonnull metadata; it it doesn't, we don't.  So "KDominatesJ" shouldn't exist, as far as I can tell; the boolean should just be "DoesKMove".


https://reviews.llvm.org/D47475





More information about the llvm-commits mailing list