[PATCH] D48798: llvm-nm: Observe -no-llvm-bc for archive members

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: test/tools/llvm-nm/X86/archive-no-llvm-bc.test:1
+; RUN: rm -rf %t && mkdir %t
+; RUN: grep -v "module asm" %s | llvm-as -o %t/embedded.bc
----------------
`mkdir -p` is probably better.


================
Comment at: test/tools/llvm-nm/X86/archive-no-llvm-bc.test:2
+; RUN: rm -rf %t && mkdir %t
+; RUN: grep -v "module asm" %s | llvm-as -o %t/embedded.bc
+; RUN: llc -I=%t -filetype=obj -o %t/obj.o %s
----------------
compnerd wrote:
> I dont understand this.  Where is embedded.bc being used?  It seems that you could completely remove this bit and still have the test work?
It's used in the incbin directive below (line 14).


Repository:
  rL LLVM

https://reviews.llvm.org/D48798