[PATCH] D49501: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc

[Matthew Voss via Phabricator via llvm-commits]

ormris created this revision.
ormris added reviewers: Maknee, dberris.
Herald added subscribers: Sanitizers, delcypher.

We've been seeing intermittent failures on our internal bots and we suspect this may be due to the OS scheduling the child process to run before the parent process.

@Maknee Is the scheduling order essential to this test?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49501

Files:
  test/xray/TestCases/Posix/fork_basic_logging.cc


Index: test/xray/TestCases/Posix/fork_basic_logging.cc
===================================================================
--- test/xray/TestCases/Posix/fork_basic_logging.cc
+++ test/xray/TestCases/Posix/fork_basic_logging.cc
@@ -70,12 +70,12 @@
 	if(fork())
 	{
 		print_parent_or_child();
-  		// CHECK: Parent with tid
+  		// CHECK-DAG: Parent with tid
 	}
 	else
 	{
 		print_parent_or_child();
-  		// CHECK: Child with tid
+  		// CHECK-DAG: Child with tid
 	}
 	return 0;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49501.156122.patch
Type: text/x-patch
Size: 484 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180718/07b892e9/attachment.bin>