[lld] r337413 - Revert r336609: Fix direct calls to __wrap_sym when it is relocated.

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Wed Jul 18 11:24:46 2018
New Revision: 337413

URL: http://llvm.org/viewvc/llvm-project?rev=337413&view=rev
Log:
Revert r336609: Fix direct calls to __wrap_sym when it is relocated.

This reverts commit r336609 as it doesn't seem to work with AArch64
thunk creation when used with ASan.

Removed:
    lld/trunk/test/ELF/wrap-plt.s
Modified:
    lld/trunk/ELF/Relocations.cpp
    lld/trunk/ELF/SymbolTable.cpp
    lld/trunk/ELF/SymbolTable.h
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Relocations.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Relocations.cpp?rev=337413&r1=337412&r2=337413&view=diff
==============================================================================
--- lld/trunk/ELF/Relocations.cpp (original)
+++ lld/trunk/ELF/Relocations.cpp Wed Jul 18 11:24:46 2018
@@ -1010,7 +1010,7 @@ static void scanReloc(InputSectionBase &
   }
 
   // If a relocation needs PLT, we create PLT and GOTPLT slots for the symbol.
-  if (needsPlt(Expr) && !Sym.isInPlt() && Sym.IsUsedInRegularObj) {
+  if (needsPlt(Expr) && !Sym.isInPlt()) {
     if (Sym.isGnuIFunc() && !Sym.IsPreemptible)
       addPltEntry<ELFT>(InX::Iplt, InX::IgotPlt, InX::RelaIplt,
                         Target->IRelativeRel, Sym);

Modified: lld/trunk/ELF/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=337413&r1=337412&r2=337413&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.cpp (original)
+++ lld/trunk/ELF/SymbolTable.cpp Wed Jul 18 11:24:46 2018
@@ -212,17 +212,6 @@ void SymbolTable::applySymbolWrap() {
   }
 }
 
-// Apply changes caused by relocations to wrapped symbols
-// This is needed for direct calls to __wrap_sym
-void SymbolTable::applySymbolWrapReloc() {
-  for (WrappedSymbol &W : WrappedSymbols) {
-    memcpy(W.Wrap, W.Sym, sizeof(SymbolUnion));
-
-    // Keep this so that this copy of the symbol remains dropped
-    W.Wrap->IsUsedInRegularObj = false;
-  }
-}
-
 static uint8_t getMinVisibility(uint8_t VA, uint8_t VB) {
   if (VA == STV_DEFAULT)
     return VB;

Modified: lld/trunk/ELF/SymbolTable.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.h?rev=337413&r1=337412&r2=337413&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.h (original)
+++ lld/trunk/ELF/SymbolTable.h Wed Jul 18 11:24:46 2018
@@ -39,7 +39,6 @@ public:
   template <class ELFT> void addCombinedLTOObject();
   template <class ELFT> void addSymbolWrap(StringRef Name);
   void applySymbolWrap();
-  void applySymbolWrapReloc();
 
   ArrayRef<Symbol *> getSymbols() const { return SymVector; }
 

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=337413&r1=337412&r2=337413&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Wed Jul 18 11:24:46 2018
@@ -1567,9 +1567,6 @@ template <class ELFT> void Writer<ELFT>:
   if (!Config->Relocatable)
     forEachRelSec(scanRelocations<ELFT>);
 
-  // Apply changes caused by relocations to wrapped symbols
-  Symtab->applySymbolWrapReloc();
-
   if (InX::Plt && !InX::Plt->empty())
     InX::Plt->addSymbols();
   if (InX::Iplt && !InX::Iplt->empty())

Removed: lld/trunk/test/ELF/wrap-plt.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/wrap-plt.s?rev=337412&view=auto
==============================================================================
--- lld/trunk/test/ELF/wrap-plt.s (original)
+++ lld/trunk/test/ELF/wrap-plt.s (removed)
@@ -1,45 +0,0 @@
-// REQUIRES: x86
-// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
-
-// RUN: ld.lld -o %t2 %t -wrap foo -shared
-// RUN: llvm-readobj -s -r %t2 | FileCheck %s
-// RUN: llvm-objdump -d %t2 | FileCheck --check-prefix=DISASM %s
-
-// CHECK:      Name: .plt
-// CHECK-NEXT: Type: SHT_PROGBITS
-// CHECK-NEXT: Flags [
-// CHECK-NEXT:   SHF_ALLOC
-// CHECK-NEXT:   SHF_EXECINSTR
-// CHECK-NEXT: ]
-// CHECK-NEXT: Address: 0x1020
-// CHECK-NEXT: Offset:
-// CHECK-NEXT: Size: 48
-// CHECK-NEXT: Link: 0
-// CHECK-NEXT: Info: 0
-// CHECK-NEXT: AddressAlignment: 16
-
-// CHECK:      Relocations [
-// CHECK-NEXT:   Section ({{.*}}) .rela.plt {
-// CHECK-NEXT:     0x2018 R_X86_64_JUMP_SLOT __wrap_foo 0x0
-// CHECK-NEXT:     0x2020 R_X86_64_JUMP_SLOT _start 0x0
-// CHECK-NEXT:   }
-// CHECK-NEXT: ]
-
-// DISASM:      _start:
-// DISASM-NEXT: jmp	41
-// DISASM-NEXT: jmp	36
-// DISASM-NEXT: jmp	47
-
-.global foo
-foo:
-  nop
-
-.global __wrap_foo
-__wrap_foo:
-  nop
-
-.global _start
-_start:
-  jmp foo at plt
-  jmp __wrap_foo at plt
-  jmp _start at plt