[PATCH] D49473: [MSan] pull insertShadowCheck() into getShadowOriginPtr(). NFC
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 18 11:26:12 PDT 2018
eugenis added a comment.
Could you simply pass the pointer shadow value as an argument to the runtime call in the kernel, and keep userspace instrumentation as it is?
================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1155
+ if (!InsPoint)
+ InsPoint = &*IRB.GetInsertPoint();
+
----------------
It's better to take a step back, add instrumentation, then take a step forward.
Must handle the start of the basic block separately.
https://reviews.llvm.org/D49473
More information about the llvm-commits
mailing list