[PATCH] D49240: [libc++] Introduce _LIBCPP_HIDE_FROM_ABI to replace _LIBCPP_INLINE_VISIBILITY

[Marshall Clow via Phabricator via llvm-commits]

mclow.lists added a reviewer: mclow.lists.
mclow.lists added inline comments.


================
Comment at: libcxx/include/__config:764
+#  define _LIBCPP_ALWAYS_INLINE __attribute__ ((__always_inline__))
+#elif _LIBCPP_COMPILER_MSVC
+#  define _LIBCPP_ALWAYS_INLINE __forceinline
----------------
We are (were) trying to keep separate sections for each compiler in `__config`

The clang section runs from line 321 - 483
The GCC section runs from line 484 - 574
The MSVC section runs from about line 575 - 606.
The IBM section runs from line 607 - 636.

I see there's a bunch of cleanup I need to do there after the 7.0 branch.



================
Comment at: libcxx/include/__config:767
+#else
+#  error "This compiler doesn't support any form of always_inline attribute"
+#endif
----------------
ldionne wrote:
> Is this acceptable?
Depends on whether or not we know of any supported compilers that don't do this.


Repository:
  rL LLVM

https://reviews.llvm.org/D49240