[PATCH] D48235: Add R_HEX_B32_PCREL_X and R_HEX_B22_PCREL_X relocations

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with these fixes.



================
Comment at: ELF/Arch/Hexagon.cpp:56-58
+  case R_HEX_B32_PCREL_X:
+  case R_HEX_B22_PCREL_X:
   case R_HEX_B22_PCREL:
----------------
Sort.


================
Comment at: ELF/Arch/Hexagon.cpp:71
     break;
+  case R_HEX_B32_PCREL_X:
+    or32le(Loc, applyMask(0x0fff3fff, Val >> 6));
----------------
Sort `case`s alphabetically.


================
Comment at: test/ELF/hexagon.s:10
 # CHECK: call 0x11000
+# R_HEX_B32_PCREL_X
+# R_HEX_B22_PCREL_X
----------------
Please insert a blank line after "CHECK" so that each testcase is visually separated.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D48235