[PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

[Aleksandr Urakov via Phabricator via llvm-commits]

aleksandr.urakov added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:291-295
+    if (udt->isConstType())
+      clang_type = clang_type.AddConstModifier();
+
+    if (udt->isVolatileType())
+      clang_type = clang_type.AddVolatileModifier();
----------------
zturner wrote:
> Can you remind me what this means?  How would an entire type be marked const or volatile?  There's no instance variable in play here, these are just types as they are declared in the source code, if I'm not mistaken.  Something like `const class Foo {int x; };` doesn't make any sense.  So I'm curious under what circumstances these 2 if statements would evaluate to true.
If I understand right, we may find ourselves here during processing of argument types of some method.


https://reviews.llvm.org/D49410