[PATCH] D49370: [AArch64] Armv8.2-A: add the crypto extensions

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

There are some variants of the PMULL instruction which depend on HasCrypto, which I think should be changed to HasAES.



================
Comment at: lib/Target/AArch64/AArch64InstrFormats.td:10038
+class CryptoRRR_2D<bits<1> op0, bits<2>op1, string asm>
+  : CryptoRRR<op0, op1, (outs V128:$Vd), (ins V128:$Vn, V128:$Vm), asm,
+              "{\t$Vd.2d, $Vn.2d, $Vm.2d}">;
----------------
Some of these input operands look wrong to me. For example, this one is used by SHA512SU1, which should have three inputs, the first of which is tied to the output.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4772
+                            SmallVector<StringRef, 4> &RequestedExtensions) {
+  const AArch64::ArchKind Arch =
+      CpuStr.empty() ? ArchKind
----------------
I think it would be better to parse this in parseDirectiveCPU, and always pass an ArchKind to this function.


https://reviews.llvm.org/D49370