[PATCH] D49402: [STLExtras] Add size() for arrays

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 18 02:08:39 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D49402#1165541, @efriedma wrote:

> This appears to be identical to llvm::array_lengthof; do you plan to deprecate that function?


Good catch! I agree with a simple swap from one to the other at some point, but actually, maybe we should just abandon this change, and use array_lengthof, until we are ready to use C++17 directly? It would make the find/replace much easier: I took a quick look, and it looks like array_lengthof is solely used for this particular function, and not some other invocation. But "size" on the other hand will be much harder to isolate.


Repository:
  rL LLVM

https://reviews.llvm.org/D49402





More information about the llvm-commits mailing list