[PATCH] D49412: Enrich inline messages

[Yevgeny Rouban via Phabricator via llvm-commits]

yrouban marked an inline comment as done.
yrouban added inline comments.


================
Comment at: lib/Transforms/IPO/Inliner.cpp:442
              << NV("Callee", Callee) << " not inlined into "
-             << NV("Caller", Caller) << " because too costly to inline (cost="
-             << NV("Cost", IC.getCost())
-             << ", threshold=" << NV("Threshold", IC.getThreshold()) << ")";
+             << NV("Caller", Caller) << " because too costly to inline ("
+             << IC << ")";
----------------
tejohnson wrote:
> nit: suggest changing to:
>              << NV("Caller", Caller) << " because too costly to inline with " << IC;
> so that you don't end up with 2 levels of nested parentheses in messages.
do you mind if I put ':' before inline cost in both cases?
  << " because it should never be inlined: " << IC;
  << " because too costly to inline: " << IC;



Repository:
  rL LLVM

https://reviews.llvm.org/D49412