[PATCH] D48663: [Power9] Code Cleanup - Remove needsAggressiveScheduling()

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 13:28:47 PDT 2018


echristo added a comment.





================
Comment at: lib/Target/PowerPC/PPCSubtarget.cpp:187
+  // The GenericScheduler that we use defaults to scheduling bottom up only.
+  // We want to schedule from both the top and the bottom and so we set
+  // OnlyBottomUp to false.
----------------
nemanjai wrote:
> I agree with Eric, please add the reason. Perhaps `We want to do bi-directional scheduling since it provides a more balanced schedule leading to better performance.`
Yeah... though that's not even really a reason, just describing the effect. :\


https://reviews.llvm.org/D48663





More information about the llvm-commits mailing list