[PATCH] D49445: [COFF] Add more missing MSVC ARM64 intrinsics

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 12:57:45 PDT 2018


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM except for the minor comment



================
Comment at: lib/Headers/intrin.h:302
 
-#if defined(__x86_64__) || defined(__arm__)
+#if defined(__x86_64__) || defined(__arm__) || defined(_M_ARM64)
 
----------------
This ifdef feels a bit inconsistent; when the other existing ones are in the form `__x86_64__` and `__arm__` (and not `_M_X64` or `_M_ARM`), the last one should probably be `__aarch64__` as well. Both here and in the testcase.


https://reviews.llvm.org/D49445





More information about the llvm-commits mailing list