[PATCH] D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 09:52:49 PDT 2018


peter.smith added a comment.

Can you elaborate on why the armhf buildbot failed and why you have excluded armhf from the MATCHES expression above. A simple test of a source file containing

  __VFP_FP__

clang --target=arm-linux-gnueabihf -E vfp.c gives me

  # 1 "vfp.c"
  # 1 "<built-in>" 1
  # 1 "<built-in>" 3
  # 361 "<built-in>" 3
  # 1 "<command line>" 1
  # 1 "<built-in>" 2
  # 1 "vfp.c" 2
  1

Unless I'm missing something a target of arm-linux-gnueabihf would define the macro unless the fpu were disabled with -mfpu=none so it should come through the test with the right answer.


https://reviews.llvm.org/D47217





More information about the llvm-commits mailing list