[PATCH] D49420: [DebugInfo] Generate .debug_names section when it makes sense

[Pavel Labath via Phabricator via llvm-commits]

labath marked an inline comment as done.
labath added inline comments.


================
Comment at: test/DebugInfo/X86/string-offsets-table.ll:94
 ; SPLIT:      .debug_str_offsets contents:
-; SPLIT-NEXT: 0x00000000: Contribution size = 12, Format = DWARF32, Version = 5
+; SPLIT-NEXT: 0x00000000: Contribution size = 20, Format = DWARF32, Version = 5
 ; SPLIT-NEXT: 0x00000008: 00000000{{.*}}
----------------
probinson wrote:
> I take it there's another string to check here?  Please add that check.
Yes, there are two more strings now which are used in the debug_names section.

BTW, this reminded me: We currently put **all** debug_str strings into the debug_str_offsets table. However, the strings, which are only used from the debug_names section (which can be most of them in split-dwarf), don't need/use the debug_str_offsets indirection as the debug_names section contains an embedded mini-offset-table.

Do you think it would make sense/be valid DWARF to restrict the debug_str_offsets table only to those strings which actually are referenced via the DW_FORM_strx and likes (in a separate patch, of course)?


Repository:
  rL LLVM

https://reviews.llvm.org/D49420