[PATCH] D46427: [PDB] Quote linker arguments containing spaces (mimic MSVC)

Will Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 17 08:17:48 PDT 2018


lantictac added a comment.

In https://reviews.llvm.org/D46427#1165040, @stefan_reinalter wrote:

> In https://reviews.llvm.org/D46427#1102066, @lantictac wrote:
>
> > Also: Just noticed that response files aren't being expanded inline in the stored command-line (as per MSVC link.exe). I'll open a bug for it.
>
>
> Second that.
>  Would be nice to expand response files. Did you open a bug for this/are you working on this?


The bug is here: 38085 <https://bugs.llvm.org/show_bug.cgi?id=38085>. I started looking into it and it looks like it ought to be fairly simple to implement since LLD already has to generate the expanded arguments. The only challenge is passing them back to the PDB generation code. Probably won't get to it this week however.


https://reviews.llvm.org/D46427





More information about the llvm-commits mailing list