[PATCH] D49379: lldbsuite: ignore decoding errors in _encoded_write

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In https://reviews.llvm.org/D49379#1164949, @kbaladurin wrote:

> Thank you for comments, I've updated patch. I agree that it is not complete solution, maybe better to make all tests unicode safe.


I've been debating this with myself yesterday. In the case you encountered, the issue is that the c string we read from the inferior is not valid utf8. This is kind of a problem because it means that it can corrupt subsequent lldb output (most likely the closing `"` character).

One possibility here would be to do the replacement character substitution directly when printing out strings read from inferior memory. However, I couldn't decide for myself whether I want my debugger to mess with these strings or not...


https://reviews.llvm.org/D49379