[PATCH] D49022: [Polly-ACC] disallow managed memory code generation for OpenCL
Philip Pfaffe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 17 05:51:14 PDT 2018
philip.pfaffe added a comment.
Thank, only nits left!
Please upload future patches with the full context: `diff -U999999 <ref-base>`, or use the arcanist tool. Otherwise you can't browse it with phabricator.
================
Comment at: include/polly/CodeGen/PPCGCodeGeneration.h:30
+/// CUDA managed memory
+bool useManagedMemory(GPUArch Arch, GPURuntime Runtime);
+
----------------
Is this outside the namespace?
================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:93
cl::cat(PollyCategory));
-
bool polly::PollyManagedMemory;
----------------
This change is unrelated.
================
Comment at: lib/Support/RegisterPasses.cpp:245
namespace polly {
+
void initializePollyPasses(PassRegistry &Registry) {
----------------
Unrelated change.
Repository:
rPLO Polly
https://reviews.llvm.org/D49022
More information about the llvm-commits
mailing list