[PATCH] D49137: [dsymutil] Implement DWARF5 accelerator tables.

[Pavel Labath via Phabricator via llvm-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D49137#1164857, @JDevlieghere wrote:

> Update logic for picking the default accelerator table kind:
>
> > If we've only seen either Apple or DWARF accelerator tables, we pick the
> >  respective one. If we've seen neither or both, the choice is determined
> >  based on the lower DWARF version encountered.


The new behavior makes more sense.

Apart from the out of date comment, this looks good to me (though I can't say I know much about how dsymutil works internally).



================
Comment at: llvm/tools/dsymutil/DwarfLinker.h:164-166
     /// Clear compile units and ranges.
     void Clear() {
       Ranges.clear();
----------------
I don't know why you deleted the other clear statement, but in any case, the comment is now out of date.


https://reviews.llvm.org/D49137