[PATCH] D48467: [X86] Recognize a splat of negate in isFNEG

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:36852
+      if (auto *C = cast_or_null<ConstantFP>(
+              getTargetConstantFromNode(Op1.getOperand(0))))
+        if (IsNeg(C))
----------------
Are there any circumstances that this isn't a ConstantFP? getTargetConstantFromNode peeks through bitcasts so don't you need to use dyn_cast_or_null?


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:36863
+      if (C->getType()->isVectorTy()) {
+        if (auto *SplatV = cast_or_null<ConstantFP>(C->getSplatValue()))
+          if (IsNeg(SplatV))
----------------
dyn_cast_or_null?


Repository:
  rL LLVM

https://reviews.llvm.org/D48467