[PATCH] D49372: [llvm-objdump] - Stop reporting bogus section IDs.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of minor improvements to the test.



================
Comment at: test/tools/llvm-objdump/X86/section-index.s:9
+
+## Check we report the valid section index for .bar
+# RUN: llvm-objdump -section-headers -section=.bar %t \
----------------
I'd update the comment to explicitly mention "when requesting a specific section".


================
Comment at: test/tools/llvm-objdump/X86/section-index.s:13
+# BAR:      Idx Name
+# BAR-NEXT:  4  .bar
+
----------------
Maybe you might want to check that no other sections are printed?


https://reviews.llvm.org/D49372