[PATCH] D49399: Move some utility classes to header files
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 16 13:48:33 PDT 2018
zturner created this revision.
zturner added reviewers: dblaikie, chandlerc, bogner.
Herald added subscribers: hiraditya, mgorny.
There were a bunch of useful utility classes and compiler test macros stashed away inside of `ItaniumDemangle.cpp`. A long time ago, in https://reviews.llvm.org/D34667, there was an attempt to add a Microsoft demangler. It got stalled but I'm intending to pick this up and finish it off. It had done a lot of the same stuff as was already being done in the helper classes in `ItaniumDemangle.cpp` such as testing for various compiler features, copying `StringView` from LLVM, etc. So all of the stuff that would be useful to a different demangler, I'm moving out into header files which can be included by the Microsoft demangler. In a followup patch, I'll rebase Rui's work on top of the new changes, finish it up, and then upload a new version of the MS demangler.
https://reviews.llvm.org/D49399
Files:
llvm/lib/Demangle/CMakeLists.txt
llvm/lib/Demangle/Compiler.h
llvm/lib/Demangle/ItaniumDemangle.cpp
llvm/lib/Demangle/StringView.h
llvm/lib/Demangle/Utility.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49399.155754.patch
Type: text/x-patch
Size: 15198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180716/6396bed3/attachment.bin>
More information about the llvm-commits
mailing list