[PATCH] D49016: [llvm-objdump] Add dynamic section printing to private-headers option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 13:19:03 PDT 2018


paulsemel added inline comments.


================
Comment at: include/llvm/Object/ELF.h:493
+  if (End->d_tag != ELF::DT_NULL)
+    return createError("dynamic sections must be DT_NULL terminated");
+
----------------
paulsemel wrote:
> I don't think we need to issue an error here actually
My bad.. old comment


Repository:
  rL LLVM

https://reviews.llvm.org/D49016





More information about the llvm-commits mailing list