[PATCH] D49380: [ARM] Remove some code from PerformCMOVCombine

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 12:52:32 PDT 2018


efriedma added a comment.

The code in question is hit pretty frequently; see http://lab.llvm.org:8080/coverage/coverage-reports/all/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Target/ARM/ARMISelLowering.cpp.html#L12550 .  Maybe we don't have any tests which check this particular aspect of the output, though.

> The provided test case was performing movne r0, r0 for the return value.

That's obviously not ideal, but deleting the transform isn't really improving the situation.  (https://rise4fun.com/Alive/slIT ).


https://reviews.llvm.org/D49380





More information about the llvm-commits mailing list