[PATCH] D49160: [WebAssembly] Added default stack-only instruction mode for MC.

[Jacob Gravelle via Phabricator via llvm-commits]

jgravelle-google added a comment.

I kinda like the use of two separate testing mode flags, to avoid needing to refactor every test to the explicit local form right away.



================
Comment at: test/CodeGen/WebAssembly/reg-stackify-stack.ll:5
 
+; NOTE: These are the same tests as in reg-stackify.ll, but using stack based
+; output instead of register output. We use register ouput for tests since it
----------------
This is probably better merged with reg-stackify.ll, with two RUN commands and a `--check-prefix` arg passed to FileCheck. See test/CodeGen/WebAssembly/signext-inreg.ll for an example of the prefixing


================
Comment at: test/CodeGen/WebAssembly/reg-stackify-stack.ll:16
 ; CHECK-LABEL: no0:
-; CHECK: return $1{{$}}
+; CHECK: return
 define i32 @no0(i32* %p, i32* %q) {
----------------
Probably worth the `{{$}}` on these two returns?


Repository:
  rL LLVM

https://reviews.llvm.org/D49160