[PATCH] D49362: [ThinLTO] Compute constant references

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a comment.

> I think it would be cleaner/clearer to encode this info along with the Ref edges

This would be a bit of overhead for global to global refs, wouldn't it? We can't make any assumption about them until we traverse an entire index.

> When importing a variable definition when the ref has this bit set, it can be imported as a local copy, without promoting the name/linkage type

What if we have non-static variable? We can't make a local copy of it, but opt pass can still handle this case if there are no external references

> Will we miss some cases if the reference is on something like a bitcast that feeds a non-volatile load?

I'll check


https://reviews.llvm.org/D49362