[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 12:08:44 PDT 2018


thakis added a comment.

Sorry about missing this. Looks great, thanks for doing this. This was a pretty big omission, glad to see it's done now :-)

I always imagined we might reuse the precompiled preamble stuff (Lexer::ComputePreamble() etc), but it's pretty clear as-is.


Repository:
  rC Clang

https://reviews.llvm.org/D46652





More information about the llvm-commits mailing list