[PATCH] D49342: [LSV] Refactoring + supporting bitcasts to a type of different size

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:393
+  // ValA, we're okay.
   if (OpB->getOpcode() == Instruction::Add &&
+      ((isa<ConstantInt>(OpB->getOperand(0)) &&
----------------
I do not think this can happen. There is a convention to have constant operand always at the last position in a commutative operation. Do you see it in a real world example or just in the artificially crafted testcase?


Repository:
  rL LLVM

https://reviews.llvm.org/D49342