[PATCH] D47811: [PATCH] [DWARF] Kotlin language
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 16 08:11:02 PDT 2018
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with Adrian's comment addressed.
================
Comment at: include/llvm/BinaryFormat/Dwarf.def:665
HANDLE_DW_LANG(0x0025, BLISS, 5, DWARF)
+HANDLE_DW_LANG(0x0026, Kotlin, 5, DWARF)
// Vendor extensions:
----------------
aprantl wrote:
> aprantl wrote:
> > I think this should be "6", not "5"?
> Could you please also add a
> `// Tentative DWARF v.6 definitions.`
> comment above to drive home the point that these are subject to change?
>
> thanks!
I think Adrian meant `DWARF v6` without the dot as we currently stylize `DWARF v5`.
Repository:
rL LLVM
https://reviews.llvm.org/D47811
More information about the llvm-commits
mailing list