[PATCH] D48828: [InstSimplify] fold extracting from std::pair

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 16 07:43:40 PDT 2018


spatel added a comment.

All of the tests for instsimplify are already folded if you run -instcombine. Could the motivating problem also be considered a pass ordering bug?

If this is going to be an instsimplify patch, then I agree with the previous feedback: the code comments should use IR examples and explain what is happening to analyze/transform the IR instructions. C++ examples just confuse things.


https://reviews.llvm.org/D48828





More information about the llvm-commits mailing list