[PATCH] D48754: [InstCombine] canonicalize abs pattern

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4520
     return true;
 
   // Y = sub (0, X)
----------------
There is some white space difference in this file. It should not be included in this patch now.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:836
+
+  // Create the canoical RHS: RHS = sub (0, LHS).
+  if (!match(RHS, m_Neg(m_Specific(LHS)))) {
----------------
typo: canoical


https://reviews.llvm.org/D48754